[utils] Prevent is_staff from erroring if roles are None #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laggron42
reviewed
Jan 9, 2025
| roles = settings.admin_role_ids + settings.root_role_ids | ||
| if any(role.id in roles for role in interaction.user.roles): # type: ignore | ||
| return True | ||
| if isinstance(interaction.user, discord.Member): |
There was a problem hiding this comment.
This check isn't enough, from my understanding the issue is that roles returned by the API are None, if the base type of the user was discord.User to begin with, then the attribute roles wouldn't exist at all. I am pretty confident that all users we are dealing with are always discord.Member objects, so instead you need to filter out the items from member.roles that are empty
|
closing, as it was a ballsdex issue only, and this wont fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #485