fixed /player delete. #281
Conversation
There was a problem hiding this comment.
Hey, thanks for the contribution!
However, this is not the right way to do things as we need the Player object to be deleted for GDPR purposes. What should be done instead is to modify the SQL schema such that deleting a row does not cascade over a trade model.
Sorry, I know it's annoying having to redo things, especially given how painful aerich can be, if you want I can walk you through this, I contacted you on Discord.
|
Hi... Sorry i couldn't respond earlier since I was travelling on vacation. I am free now and can respond as soon as possible |
|
Pending discussion on #346 |
Kowlin
added
the
blocked
|
Hi there, we plan on making a soft delete functionality so I believe this PR will no longer be needed when that comes along. We appreciate the work put in thus far. |
I saw the bug report in the server that it does not show if the ball is traded if the user who gave that ball deletes their data afterwards. This should fix it since now only the instances the player owns are getting deleted and not all the player data. Please review