RowMajor CQRRPT [WiP]
#95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aryamanjeendgar I pulled your code and tested it locally, everything passed, so I'm presuming that it was the regular CQRRPT tests that were failing for you (per your message in Slack). Lmk once you enable the row-major tests. P.S. not yet sure what is up with Got workflow, will figure it out shortly. |
|
@aryamanjeendgar looks like I am unable to modify files here bc you made a fork. |
|
@aryamanjeendgar Sorry, macos yaml file also needs updating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to enable CQRRPT to support
RowMajorinputs.I have tweaked the existing tests in
test_cqrrpt.ccto testRowMajorinputs as well (by just storing aRowMajorcopy of the test matrix on hand).The actual CQRRPT call is still WiP