-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: positive definite kernels, randomly pivoted Cholesky, and more (rebase of PR #72) #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync attempt
…econd class to facilitate applying Nystrom and RPCholesky preconditioners.
…ricLinearOperator interface
…tor, ExplicitSymLinOp, and RegExplicitSymLinOp
…nd require that the right-hand-sides are fully-specified (rather than copying a vector RHS into columns of a matrix RHS).
… matrices with polynomial spectral decay
…regularization parameter is only included if a third argument is provided (A(i,j,true)). Remove the requirement of implementing operator()(int64_t i, int64_t j) from the SymmetricLinearOperator abstract class
…oper tests for krill_separable_rpchol
…parallel for statement for evaluating the exponential function in the squared exponential kernel. Improve efficiency of initializing Eds in euclidean_distance_submatrix.
…ead of an "evaluate()" function
…ementation so that it can handle either separable or block problems
…ction in rl_preconditioners.hh.
…ng. I want to merge-in the latest main before trying to fix the failing QB test.
@TeachRaccooon, one of the QB tests is failing. Can you take a look?
Seems this is compiler-dependent. For posterity, my compiler and cmake are
I ended up being able to fix this by disabling compiler optimizations in Random123's boxmuller.hpp file. Don't ask me how I zero'd in on that. |
…ry revision of rl_version.cmake
…to RBFKernelMatrix.
TeachRaccooon
added a commit
that referenced
this pull request
Jan 31, 2025
I'll be splitting PR #85 into two (or perhaps three) PRs. This is the first of those. TODONEs: * add documentation to the new pcg functions. * reduce dependence of callable preconditioners on std::vector. * reduce dependence of pcg functions (new and old) on std::vector. I'm deferring documentation to symmetric linear operators and preconditioners to a subsequent PR, since I plan on switching from a class/inheritance-based linear operator API to an API using C++20 concepts. --------- Co-authored-by: Max Melnichenko <[email protected]>
This is superseded by PR #100. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes so far:
Infrastructure:
Abstract linear operators (see /misc/rl_linops.hh):
operator()(int64_t i, int64_t j)
to SymmetricLinearOperator.evaluate
function as well asoperator()(... BLAS-like args ...)
functions. The reason for the class is to seamlessly handle working with separable problems vs with block problems, and to transform the eigenvalues/singular values so that a matvec with the preconditioner takes two matvecs with the factor matrices, instead of three.Positive definite kernels (see /misc/rl_pdkernels.hh):
Randomly pivoted Cholesky (see /comps/rl_rpchol.hh):
K_stateless(i, j)
.Deterministic iterative solvers
pcg
topcg_saddle
.Preconditioner generation