Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nov23 cqrrpt #60

Merged
merged 10 commits into from
Nov 17, 2023
Merged

Nov23 cqrrpt #60

merged 10 commits into from
Nov 17, 2023

Conversation

TeachRaccooon
Copy link
Contributor

Reworked CQRRPT and CQRRP benchmarks,
CQRRPT is now fully pointer-based.

@TeachRaccooon
Copy link
Contributor Author

@rileyjmurray can you take a look at this?

rileyjmurray
rileyjmurray requested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@rileyjmurray rileyjmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See individual comments.

RandLAPACK/drivers/rl_cqrrpt.hh Outdated Show resolved Hide resolved
benchmark/bench_CQRRP/CQRRP_accuracy.cc Outdated Show resolved Hide resolved
benchmark/bench_CQRRP/CQRRP_inner_speed.cc Outdated Show resolved Hide resolved
benchmark/bench_CQRRPT/CQRRPT_accuracy.cc Outdated Show resolved Hide resolved
benchmark/bench_CQRRPT/CQRRPT_inner_speed.cc Outdated Show resolved Hide resolved
rileyjmurray
rileyjmurray approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@rileyjmurray rileyjmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merge once tests pass!

@TeachRaccooon TeachRaccooon merged commit 59f6284 into main Nov 17, 2023
2 checks passed
@TeachRaccooon TeachRaccooon deleted the NOV23_CQRRPT branch November 17, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileyjmurray rileyjmurray rileyjmurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TeachRaccooon @rileyjmurray