CQRRP (blocked CQRRPT)

.github/workflows/core-linux.yaml

@@ -27,7 +27,11 @@ jobs:
           export DEBIAN_FRONTEND="noninteractive"
           export TZ="America/Los_Angeles"
           sudo apt-get update -qq
-          sudo apt-get install -qq -y git-core gcc g++ gfortran cmake subversion automake m4 libgtest-dev libmkl-dev libopenblas-openmp-dev
+          sudo apt-get install -qq -y git-core gcc g++ gfortran cmake subversion automake m4 libgtest-dev libopenblas-openmp-dev
+          wget -O- https://apt.repos.intel.com/intel-gpg-keys/GPG-PUB-KEY-INTEL-SW-PRODUCTS.PUB \
+          | gpg --dearmor | sudo tee /usr/share/keyrings/oneapi-archive-keyring.gpg > /dev/null
+          echo "deb [signed-by=/usr/share/keyrings/oneapi-archive-keyring.gpg] https://apt.repos.intel.com/oneapi all main" | sudo tee /etc/apt/sources.list.d/oneAPI.list
+          sudo apt update
 
       - name: install BLAS++
         run: |
@@ -53,7 +57,7 @@ jobs:
           mkdir lapackpp-build
           cd lapackpp-build
           cmake -DCMAKE_BUILD_TYPE=Debug \
-              -Dblaspp_DIR=`pwd`/../blaspp-install/lib/blaspp \
+              -Dblaspp_DIR=`pwd`/../blaspp-install/lib/cmake/blaspp \
               -DCMAKE_INSTALL_PREFIX=`pwd`/../lapackpp-install \
               -DCMAKE_BINARY_DIR=`pwd` \
               -Dbuild_tests=OFF \
@@ -66,8 +70,8 @@ jobs:
           mkdir RandLAPACK-build
           cd RandLAPACK-build
           cmake -DCMAKE_BUILD_TYPE=Release \
-              -Dblaspp_DIR=`pwd`/../blaspp-install/lib/blaspp \
-              -Dlapackpp_DIR=`pwd`/../lapackpp-install/lib/lapackpp \
+              -Dblaspp_DIR=`pwd`/../blaspp-install/lib/cmake/blaspp \
+              -Dlapackpp_DIR=`pwd`/../lapackpp-install/lib/cmake/lapackpp \
               -DRandom123_DIR=`pwd`/../Random123-install/include/ \
               -DCMAKE_INSTALL_PREFIX=`pwd`/../RandLAPACK-install \
               `pwd`/../RandLAPACK
@@ -92,8 +96,8 @@ jobs:
           cd RandLAPACK-build-asan
           cmake -DCMAKE_BUILD_TYPE=Debug \
               -DSANITIZE_ADDRESS=ON \
-              -Dblaspp_DIR=`pwd`/../blaspp-install/lib/blaspp \
-              -Dlapackpp_DIR=`pwd`/../lapackpp-install/lib/lapackpp \
+              -Dblaspp_DIR=`pwd`/../blaspp-install/lib/cmake/blaspp \
+              -Dlapackpp_DIR=`pwd`/../lapackpp-install/lib/cmake/lapackpp \
               -DRandom123_DIR=`pwd`/../Random123-install/include/ \
               -DCMAKE_INSTALL_PREFIX=`pwd`/../RandLAPACK-install-asan \
               `pwd`/../RandLAPACK

.github/workflows/core-macos.yaml

@@ -50,7 +50,7 @@ jobs:
           mkdir lapackpp-build
           cd lapackpp-build
           cmake -DCMAKE_BUILD_TYPE=Debug \
-              -Dblaspp_DIR=`pwd`/../blaspp-install/lib/blaspp \
+              -Dblaspp_DIR=`pwd`/../blaspp-install/lib/cmake/blaspp \
               -DCMAKE_INSTALL_PREFIX=`pwd`/../lapackpp-install \
               -DCMAKE_BINARY_DIR=`pwd` \
               -Dbuild_tests=OFF \
@@ -63,8 +63,8 @@ jobs:
           mkdir RandLAPACK-build
           cd RandLAPACK-build
           cmake -DCMAKE_BUILD_TYPE=Release \
-              -Dblaspp_DIR=`pwd`/../blaspp-install/lib/blaspp \
-              -Dlapackpp_DIR=`pwd`/../lapackpp-install/lib/lapackpp \
+              -Dblaspp_DIR=`pwd`/../blaspp-install/lib/cmake/blaspp \
+              -Dlapackpp_DIR=`pwd`/../lapackpp-install/lib/cmake/lapackpp \
               -DRandom123_DIR=`pwd`/../Random123-install/include/ \
               -DCMAKE_INSTALL_PREFIX=`pwd`/../RandLAPACK-install \
               `pwd`/../RandLAPACK
@@ -89,8 +89,8 @@ jobs:
           cd RandLAPACK-build-asan
           cmake -DCMAKE_BUILD_TYPE=Debug \
               -DSANITIZE_ADDRESS=ON \
-              -Dblaspp_DIR=`pwd`/../blaspp-install/lib/blaspp \
-              -Dlapackpp_DIR=`pwd`/../lapackpp-install/lib/lapackpp \
+              -Dblaspp_DIR=`pwd`/../blaspp-install/lib/cmake/blaspp \
+              -Dlapackpp_DIR=`pwd`/../lapackpp-install/lib/cmake/lapackpp \
               -DRandom123_DIR=`pwd`/../Random123-install/include/ \
               -DCMAKE_INSTALL_PREFIX=`pwd`/../RandLAPACK-install-asan \
               `pwd`/../RandLAPACK

RandLAPACK.hh

@@ -19,6 +19,7 @@
 // Drivers
 #include "RandLAPACK/drivers/rl_rsvd.hh"
 #include "RandLAPACK/drivers/rl_cqrrpt.hh"
+#include "RandLAPACK/drivers/rl_cqrrp.hh"
 #include "RandLAPACK/drivers/rl_revd2.hh"
 
 #endif

RandLAPACK/CMakeLists.txt

@@ -2,6 +2,7 @@
 set(RandLAPACK_cxx_sources
     rl_lapackpp.hh
     rl_cqrrpt.hh
+    rl_cqrrp.hh
     rl_rsvd.hh
     rl_revd2.hh
     rl_qb.hh

RandLAPACK/comps/rl_rs.hh

@@ -139,12 +139,12 @@ int RS<T, RNG>::call(
 
     if (p % 2 == 0) {
         // Fill n by k Omega
-        RandBLAS::DenseDist D{.n_rows = n, .n_cols = k};
-        state = RandBLAS::fill_dense(D, Omega_dat, state);
+        RandBLAS::DenseDist D(n, k);
+        state = RandBLAS::fill_dense(D, Omega_dat, state).second;
     } else {
         // Fill m by k Omega_1
-        RandBLAS::DenseDist D{.n_rows = m, .n_cols = k};
-        state = RandBLAS::fill_dense(D, Omega_1_dat, state);
+        RandBLAS::DenseDist D(m, k);
+        state = RandBLAS::fill_dense(D, Omega_1_dat, state).second;
 
         // multiply A' by Omega results in n by k omega
         blas::gemm(Layout::ColMajor, Op::Trans, Op::NoTrans, n, k, m, 1.0, A_dat, m, Omega_1_dat, m, 0.0, Omega_dat, n);

RandLAPACK/comps/rl_syps.hh

@@ -140,8 +140,8 @@ int SYPS<T, RNG>::call(
      bool callers_skop_buff = skop_buff != nullptr;
      if (!callers_skop_buff)
          skop_buff = new T[m * k];
-    RandBLAS::DenseDist D{m, k};
-    state = RandBLAS::fill_dense(D, skop_buff, state);
+    RandBLAS::DenseDist D(m, k);
+    state = RandBLAS::fill_dense(D, skop_buff, state).second;
 
      bool callers_work_buff = work_buff != nullptr;
      if (!callers_work_buff)