Skip to content

Commit

Permalink
Fix per Riley's comments
Browse files Browse the repository at this point in the history
  • Loading branch information
TeachRaccooon committed Apr 16, 2024
1 parent 8911b6b commit f7d2417
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion benchmark/bench_CQRRP/CQRRP_pivot_quality.cc
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ static void data_regen(RandLAPACK::gen::mat_gen_info<T> m_info,
QR_speed_benchmark_data<T> &all_data,
RandBLAS::RNGState<RNG> &state) {

RandLAPACK::gen::mat_gen<double>(m_info, all_data.A.data(), state);
RandLAPACK::gen::mat_gen(m_info, all_data.A.data(), state);
std::fill(all_data.tau.begin(), all_data.tau.end(), 0.0);
std::fill(all_data.J.begin(), all_data.J.end(), 0);
}
Expand Down
2 changes: 1 addition & 1 deletion benchmark/bench_CQRRP/CQRRP_single_precision.cc
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ static void data_regen(RandLAPACK::gen::mat_gen_info<T> m_info,
QR_speed_benchmark_data<T> &all_data,
RandBLAS::RNGState<RNG> &state, int apply_itoa) {

RandLAPACK::gen::mat_gen<T>(m_info, all_data.A.data(), state);
RandLAPACK::gen::mat_gen(m_info, all_data.A.data(), state);
std::fill(all_data.tau.begin(), all_data.tau.end(), 0.0);
if (apply_itoa) {
std::iota(all_data.J.begin(), all_data.J.end(), 1);
Expand Down
2 changes: 1 addition & 1 deletion benchmark/bench_CQRRP/CQRRP_speed_comparisons.cc
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ static void data_regen(RandLAPACK::gen::mat_gen_info<T> m_info,
QR_speed_benchmark_data<T> &all_data,
RandBLAS::RNGState<RNG> &state, int apply_itoa) {

RandLAPACK::gen::mat_gen<double>(m_info, all_data.A.data(), state);
RandLAPACK::gen::mat_gen(m_info, all_data.A.data(), state);
std::fill(all_data.tau.begin(), all_data.tau.end(), 0.0);
if (apply_itoa) {
std::iota(all_data.J.begin(), all_data.J.end(), 1);
Expand Down
2 changes: 1 addition & 1 deletion benchmark/bench_CQRRPT/CQRRPT_pivot_quality.cc
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ static void data_regen(RandLAPACK::gen::mat_gen_info<T> m_info,
QR_benchmark_data<T> &all_data,
RandBLAS::RNGState<RNG> &state) {

RandLAPACK::gen::mat_gen<double>(m_info, all_data.A.data(), state);
RandLAPACK::gen::mat_gen(m_info, all_data.A.data(), state);
std::fill(all_data.R.begin(), all_data.R.end(), 0.0);
std::fill(all_data.tau.begin(), all_data.tau.end(), 0.0);
std::fill(all_data.J.begin(), all_data.J.end(), 0);
Expand Down
4 changes: 2 additions & 2 deletions benchmark/bench_CQRRPT/CQRRPT_runtime_breakdown.cc
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ static void data_regen(RandLAPACK::gen::mat_gen_info<T> m_info,
QR_benchmark_data<T> &all_data,
RandBLAS::RNGState<RNG> &state) {

RandLAPACK::gen::mat_gen<double>(m_info, all_data.A.data(), state);
RandLAPACK::gen::mat_gen(m_info, all_data.A.data(), state);
std::fill(all_data.R.begin(), all_data.R.end(), 0.0);
std::fill(all_data.tau.begin(), all_data.tau.end(), 0.0);
std::fill(all_data.J.begin(), all_data.J.end(), 0);
Expand Down Expand Up @@ -124,7 +124,7 @@ int main() {
+ ".dat", std::fstream::app);

for (;n_start <= n_stop; n_start *= 2) {
res = call_all_algs<double>(m_info, numruns, n_start, all_data, state_constant);
res = call_all_algs(m_info, numruns, n_start, all_data, state_constant);
file << res[0] << ", " << res[1] << ", " << res[2] << ", " << res[3] << ", " << res[4] << ", " << res[5] << ", " << res[6] << ", " << res[7] << ",\n";
}
}
4 changes: 2 additions & 2 deletions benchmark/bench_CQRRPT/CQRRPT_speed_comparisons.cc
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ static void data_regen(RandLAPACK::gen::mat_gen_info<T> m_info,
QR_benchmark_data<T> &all_data,
RandBLAS::RNGState<RNG> &state) {

RandLAPACK::gen::mat_gen<double>(m_info, all_data.A.data(), state);
RandLAPACK::gen::mat_gen(m_info, all_data.A.data(), state);
std::fill(all_data.R.begin(), all_data.R.end(), 0.0);
std::fill(all_data.tau.begin(), all_data.tau.end(), 0.0);
std::fill(all_data.J.begin(), all_data.J.end(), 0);
Expand Down Expand Up @@ -207,7 +207,7 @@ int main() {
+ ".dat", std::fstream::app);

for (;n_start <= n_stop; n_start *= 2) {
res = call_all_algs<double>(m_info, numruns, n_start, all_data, state_constant);
res = call_all_algs(m_info, numruns, n_start, all_data, state_constant);
file << res[0] << ", " << res[1] << ", " << res[2] << ", " << res[3] << ", " << res[4] << ", " << res[5] << ",\n";
}
}
Expand Down
2 changes: 1 addition & 1 deletion test/comps/test_preconditioners.cc
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ TEST_F(TestNystromPrecond, basictest) {
mat_info.exponent = 2.0;
std::vector<double> A(m * m, 0.0);
RandBLAS::RNGState data_state(0);
RandLAPACK::gen::mat_gen<double>(mat_info, A.data(), data_state);
RandLAPACK::gen::mat_gen(mat_info, A.data(), data_state);
std::vector<double> G(m * m, 0.0);
blas::syrk(Layout::ColMajor, Uplo::Lower, Op::NoTrans, m, m, 1.0,
A.data(), m, 0.0, G.data(), m
Expand Down

0 comments on commit f7d2417

Please sign in to comment.