Fix Github Actions #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 25, 2023 22:31
…r permissions builder
fix permissions import to be local change dotmap to munch.
|
@SHAKOTN I merged my permissions stuff and tinkered with the actions againt o get them working. I'm trying to understand where to put these constants with github repo locations. Would love to hear your thoughts. |
SHAKOTN
reviewed
Jul 26, 2023
| "https://raw.githubusercontent.com/BalancerMaxis/bal_addresses/main/extras/chains.json" | ||
| ).json()) | ||
| CHAIN_IDS_BY_NAME = chains["CHAIN_IDS_BY_NAME"] |
There was a problem hiding this comment.
If you were saying that CHAIN_IDS_BY_NAME is a constant, it is not. It's actually a dict from dynamically fetched data. I recommend keeping it within the class then, but just make it lowercase :)
There was a problem hiding this comment.
Good advice, will adopt later, just merging this to get this working/base indexed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing data to AddrBook for flatbook builder and fix filename for permissions builder