Get rid of the dotmap and generate Munches for multsigs and extras too. #72
Conversation
|
ok @SHAKOTN please take another look. |
# Conflicts: # bal_addresses/__init__.py # bal_addresses/addresses.py # bal_addresses/generate_current_permissions.py # bal_addresses/permissions.py
bal_addresses/addresses.py
Outdated
| self._multisigs = Munch.fromDict(msigs[self.chain]) | ||
| else: | ||
| print(f"Warning: No multisigs for chain {self.chain}, multisigs must be added in extras/multisig.json") | ||
| self._multisigs = {} |
There was a problem hiding this comment.
Make it empty Munch object to unify the interface
| @@ -76,10 +105,36 @@ def test_deployments_invalid_format(): | |||
| } | |||
| } | |||
| ) | |||
| responses.add( | |||
There was a problem hiding this comment.
Nicely done, but please pay attention to the name of the test.
It's always good to make tests as small as possible.
My suggestion: create separate test functions for both extras and msigs logic
There was a problem hiding this comment.
I tried that but you have to copy all the inputs each time and then there is very little additional code. It felt silly and made changes to the test inputs hard.
There was a problem hiding this comment.
You should separate all the test cases in smaller units, that is my recommendation. It's better to NOT test everything in one function even if it leads to boilerplate code
No description provided.