Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only run for prod chains and raise on errors #401

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

gosuto-inzasheru
Copy link
Member

last run failed to retrieve pools and gauges for ethereum and gnosis, but the error was caught and the ci workflow continued (https://github.com/BalancerMaxis/bal_addresses/actions/runs/10252037228/job/28361482279)

mainnet
Error using core subgraph for mainnet, skipping: 429 Client Error: Too Many Requests for url: https://api.studio.thegraph.com/query/75376/balancer-v2/version/latest
polygon
arbitrum
optimism
gnosis
Error using core subgraph for gnosis, skipping: 504 Server Error: Gateway Timeout for url: https://api.studio.thegraph.com/query/75376/balancer-gnosis-chain-v2/version/latest
zkevm
goerli
Error using core subgraph for goerli, skipping: 410 Client Error: Gone for url: https://api.thegraph.com/subgraphs/name/balancer-labs/balancer-goerli-v2
Error using gauge subgraph for goerli, skipping: 410 Client Error: Gone for url: https://api.thegraph.com/subgraphs/name/balancer-labs/balancer-gauges-goerli
sepolia
Error using gauge subgraph for sepolia, skipping: Invalid URL 'None': No scheme supplied. Perhaps you meant https://None?
avalanche
fantom
base
mode
fraxtal

this results in a pr which removes all pools/gauges it couldnt retrieve, which i think should not occur ever (#400)

furthermore, the subgraphs for the testnets are not deployed and/or unreliable

suggesting here to only run pools and gauges for production chains, and raise (thus fail the workflow) if data for these chains cannot be retrieved successfully

@Tritium-VLK
Copy link
Member

@Tritium-VLK
Copy link
Member

Copy link
Member

@Tritium-VLK Tritium-VLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only OP is removed, as it is not an chain managed by the Maxis. Gos cleared this up. LGTM.

@gosuto-inzasheru gosuto-inzasheru merged commit 525db4f into main Aug 6, 2024
4 checks passed
@gosuto-inzasheru gosuto-inzasheru deleted the fix/raise_on_pools_gauges_failure branch August 6, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants