Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove linea references #389

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Conversation

gosuto-inzasheru
Copy link
Member

would be good to merge this before cron workflows kick in on thursday 0h00 utc

related to BalancerMaxis/multisig-ops#1147

@Xeonus
Copy link
Contributor

Xeonus commented Jul 29, 2024

@gosuto-inzasheru found 2 empty linea references, but not sure they will vanish after new build? Would be nice if they are gone too, right?
Outputs, see
subgraph_urls.json:

gauges.json

"linea": {},

@gosuto-inzasheru
Copy link
Member Author

aah these will indeed disappear automatically, since they are in a outputs file which will get rebuilt

Copy link
Contributor

@Xeonus Xeonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Cross-checked removal of all entries
  • output.jsons will remove empty linea entries once cron job runs

@gosuto-inzasheru gosuto-inzasheru merged commit aeab749 into main Aug 1, 2024
3 checks passed
@gosuto-inzasheru gosuto-inzasheru deleted the chore/remove_linea_references branch August 1, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants