Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.3 move queries et al to bal_tools package. #269

Merged
merged 19 commits into from
May 2, 2024

Conversation

Tritium-VLK
Copy link
Member

No description provided.

setup.py Outdated Show resolved Hide resolved
@Tritium-VLK
Copy link
Member Author

Also permissions seems to be having problems with rpc overload, not exactly related but looking into that.

Co-authored-by: gosuto.eth <[email protected]>
@Tritium-VLK Tritium-VLK marked this pull request as draft April 25, 2024 21:08
@Tritium-VLK
Copy link
Member Author

Note main perms still working: https://github.com/BalancerMaxis/bal_addresses/actions/runs/8839262089

@Tritium-VLK
Copy link
Member Author

Tritium-VLK commented Apr 25, 2024

@gosuto-inzasheru
Copy link
Member

the problem seems to be infura rate limiting us (im guessing the github ip address)

it appears to be for mainnet only, so maybe use alchemy for mainnet instead?

then for fantom, if indeed there is no authoriser there then what is all this? https://github.com/BalancerMaxis/bal_addresses/blob/main/outputs/permissions/active/fantom.json

note that either way that fantom.json file needs to exist (empty or populated), because the msig report looks for that file on every run

then finally not sure why you are commenting out base (commit message says " remove fantom rpc as there is no authorizer there. Runs locally."?)

@Tritium-VLK
Copy link
Member Author

Tritium-VLK commented Apr 29, 2024

Why does it break on the main branch?

The issue is that we don't actually have Balancer setup on Fantom, just 1 multisig there. When we added it, we pulled in a bunch of old stuff, and having fantom in the list for the authorizor runs was either pulling garbage data or crashing. We really don't want all those contracts from Fantom that are now in our docs/addressbook there as far as I know. They're not really still supported by the DAO. We can talk about that in the meeting today.

Copy link
Member

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • imports BalPoolsGauges and Subgraph from new bal tools repo
  • remove all fantom permissions, but keep json
  • move ethereum rpc calls to alchemy instead of infura

@gosuto-inzasheru
Copy link
Member

ok now it times out on optimism in infura: https://github.com/BalancerMaxis/bal_addresses/actions/runs/8893260208/job/24419053635

going to move all of them to alchemy

@gosuto-inzasheru
Copy link
Member

@gosuto-inzasheru gosuto-inzasheru marked this pull request as ready for review April 30, 2024 10:48
@Tritium-VLK
Copy link
Member Author

Tritium-VLK commented Apr 30, 2024

@gosuto-inzasheru this good to merge? Need to update version first, and then release 0.9.3 after merge.

@gosuto-inzasheru
Copy link
Member

yes sir, approving a review means i consider it ready to merge 👍

@Tritium-VLK
Copy link
Member Author

yes sir, approving a review means i consider it ready to merge 👍

Hmm. You're the last commit and I made the PR so need someone else to review before we can merge... Heh.

Will ping @Xeonus

@Tritium-VLK Tritium-VLK enabled auto-merge May 2, 2024 10:37
@Tritium-VLK Tritium-VLK merged commit c55ff45 into main May 2, 2024
5 checks passed
@Tritium-VLK Tritium-VLK deleted the 0.9.3/no_bal_addresses branch May 2, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants