Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove estimate spend function #46

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Remove estimate spend function #46

merged 2 commits into from
Oct 18, 2024

Conversation

Tritium-VLK
Copy link
Member

Seems wrong, is confusing.

@Tritium-VLK
Remove estimate spend function
805cad2 
Seems wrong, is confusing.
This was referenced Oct 16, 2024
Closed
Merged
petrovska-petro
petrovska-petro approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@petrovska-petro petrovska-petro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removes a public facing method which contains mistaken logic, it is not used in any core logic on the rest of the contract. safe to removed ✅

@petrovska-petro petrovska-petro merged commit d4639f5 into main Oct 18, 2024
1 check passed
@petrovska-petro petrovska-petro deleted the remove_estimate_spend branch October 18, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrovska-petro petrovska-petro petrovska-petro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tritium-VLK @petrovska-petro