BAH-4157 | Migrate HIP Initiated Linking Flow to use ABDM v3 APIs #181
Conversation
| break; | ||
| } | ||
| i++; | ||
| } while (i < gatewayConfiguration.Counter); |
There was a problem hiding this comment.
Instead of a loop,can we consider an event-driven mechanism that waits asynchronously for updates to UserAuthMap?
There was a problem hiding this comment.
This approach is taken consciously to keep it simple. Also, the execution needs to wait until we get a linking token to proceed with linking of care-context. This is added since to token comes on a callback response from gateway
| } | ||
| var authConfirm = new AuthConfirm(healthId, accessToken); | ||
| var savedAuthConfirm = userAuthRepository.Get(healthId).Result; | ||
| if (savedAuthConfirm.Equals(Option.Some<AuthConfirm>(null))) |
There was a problem hiding this comment.
Why are we not using simpler, clearer null-checks? Like,
if (savedAuthConfirm == null)
There was a problem hiding this comment.
This is checked in this way because the return for userAuthRepository.Get is always an Option instead of a null. So a simple null check would return false since the object would be initialised with an instance of Option having a null value.
This PR incorporates the following changes