BAH-4033 | Refactor. Throw validation exception when a concept cannot be matched for a given task_type #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assed and a matching concept is not found
mohan-13
requested review from
angshu,
binduak,
kavitha-sundararajan,
Arjun-Go,
parvathy00 and
rahu1ramesh
angshu
reviewed
Jul 22, 2024
| log.warn("Task type is not passed. Setting as null"); | ||
| return null; | ||
| } | ||
| Concept conceptForTaskType = Context.getConceptService().getConceptByName(taskType); |
There was a problem hiding this comment.
This conceptService method will consider userLocale first.
If you expect the taskType to be provided as "user input" then the above is good.
Alternatively, if it is to be specified by implementation locale, this might be a better option. conceptService.getConceptsByName(name, locale, false)
where you get the LocalUtility.getDefaultLocale()
If this method is called by both human and non-human user inputs - then
conceptService.getConcepts(conceptName, localeList, false, null, null, null, null, null, 0, null)
Might be better.
angshu
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the TaskMapper implementation to throw a
ValidationExceptionwhich in turn will lead to 400 Bad Request error when a taskType is passed and a corresponding concept matching the given name cannot be identified.This is enhancement is done to allow implementers configure their implementation specific task types and get a proper error when a concept cannot be matched.
JIRA Epic: https://bahmni.atlassian.net/browse/BAH-4032