Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAH-4149: Bump Bahmni Core version to 1.3.0-SNAPSHOT and FHIR2 version to 2.3.0-SNAPSHOT. #215

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ruhanga
Copy link
Contributor

@Ruhanga Ruhanga commented Dec 9, 2024

This is a follow-on PR based on the changes discussed here.

This PR will ensure the following upgrades:

  • Bahmni Core 1.3.0-SNAPSHOT allows Bahmni Core liquibase runnable on Maria DB reference.
  • FHIR2 2.3.0-SNAPSHOT fixes the issue with its api failing to access another modules api reference.

@Ruhanga Ruhanga changed the title Bump Bahmni Core version to 1.3.0-SNAPSHOT. Bump Bahmni Core version to 1.3.0-SNAPSHOT and FHIR2 version to 2.3.0-SNAPSHOT. Dec 15, 2024
@@ -50,7 +50,7 @@
<bahmniIEOmodVersion>1.4.0</bahmniIEOmodVersion>
<appointmentsVersion>2.0.2</appointmentsVersion>
<pacsQueryVersion>1.4.0</pacsQueryVersion>
<fhir2ModuleVersion>2.1.0</fhir2ModuleVersion>
<fhir2ModuleVersion>2.3.0-SNAPSHOT</fhir2ModuleVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ruhanga This bumps two versions, would be great if you can add on the description on what enhancement / breaking change we might have.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ruhanga Can you please raise a JIRA ticket and associate with descriptions and associate the PR to the card

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @mohan-13. I've tracked this through the ticket: BAH-4149

@Ruhanga Ruhanga changed the title Bump Bahmni Core version to 1.3.0-SNAPSHOT and FHIR2 version to 2.3.0-SNAPSHOT. BAH-4149: Bump Bahmni Core version to 1.3.0-SNAPSHOT and FHIR2 version to 2.3.0-SNAPSHOT. Dec 17, 2024
@mohan-13
Copy link
Member

@Ruhanga I can see that the build on the upstream for fhir2 module is failing. https://github.com/openmrs/openmrs-module-fhir2/actions/runs/12319449923. Hope that should be fixed for your changes to be published

@Ruhanga
Copy link
Contributor Author

Ruhanga commented Dec 19, 2024

Good catch, thanks for the observations @mohan-13. Let me let the community know of the build failure so it can be resolved ASAP before you can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants