Remove auto-appended assembly-id suffix to final distro zip artefact

[Ruhanga]

This PR intends to avoid appending the assembly Id (distro) to the final distro zip package.
i.e distro-1.2.0-SNAPSHOT-distro.zip ➔ distro-1.2.0-SNAPSHOT.zip

[mohan-13]

@Ruhanga While this change looks good to me, please be noted that the zip artifact is not published to artifactory. Instead the github actions only publishes the docker image

[rbuisson]

Hi @mohan-13 , is there any way to get the distro Zip published to Artifactory (and not only used in the build of the Docker image)?

[mohan-13]

Hi @mohan-13 , is there any way to get the distro Zip published to Artifactory (and not only used in the build of the Docker image)?

@rbuisson Would like to understand what is the use-case for publishing the OMODs distro zip?

[rbuisson]

@mohan-13 , we at Mekom are creating our own Maven distributions for clients. To put together such distributions, and yet stay in line with the community Bahmni distribution, we want to be able to use openmrs-distro-bahmni as a dependency.
On top of that, we'll add/remove modules, adjust configs... and publish a new distro (as a Zip file) that contains all configs and binaries necessary for that client.
As a second phase, we're publishing our own Docker images that contain such binaries and configs.

For that reason, it is necessary to be able to use openmrs-distro-bahmni as Maven dependency, thus need it published somewhere.
Does that make sense?

[mohan-13]

@mohan-13 , we at Mekom are creating our own Maven distributions for clients. To put together such distributions, and yet stay in line with the community Bahmni distribution, we want to be able to use openmrs-distro-bahmni as a dependency. On top of that, we'll add/remove modules, adjust configs... and publish a new distro (as a Zip file) that contains all configs and binaries necessary for that client. As a second phase, we're publishing our own Docker images that contain such binaries and configs.

For that reason, it is necessary to be able to use openmrs-distro-bahmni as Maven dependency, thus need it published somewhere. Does that make sense?

While we can look if that can be possible, our recommendation would be use bahmni/openmrs as a docker image and add/remove modules that you would need to build your own distribution. This would reduce the number of artifacts that needs management.

Another approach could be, the distro project in this repo does nothing but just assembling modules from repositories into the target/distro folder. So why not have a similar setup and add/remove your dependenices and build an your client specific distro.