Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAH-700 | Lab Results page sorting issue #19

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

BAH-700 | Lab Results page sorting issue #19

wants to merge 6 commits into from

Conversation

sai789
Copy link
Contributor

@sai789 sai789 commented Dec 11, 2018

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2018

CLA assistant check
All committers have signed the CLA.

try {
return Integer.parseInt(firstResult.getTestSortOrder()) - Integer.parseInt(secondResult.getTestSortOrder());
} catch (NumberFormatException e) {
return firstResult.getTestName().compareTo(secondResult.getTestName());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handling logic in the catch block is a code smell. Please handle main logic part in the try block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants