Remove Set-PodeResponseStatus when status is 200

Badgerati · Apr 4, 2024 · 71149e1 · 71149e1
1 parent d54d1ab
commit 71149e1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 15 deletions.
diff --git a/src/Private/Helpers.ps1 b/src/Private/Helpers.ps1
@@ -1766,22 +1766,21 @@ function Test-PodePath {
 
     }
 
-    # if we failed to get the file, report back the status code and/or return true/false
-    if (!$NoStatus.IsPresent) {
-        Set-PodeResponseStatus -Code $statusCode
+    if ($statusCode -eq 200) {
+        if ($ReturnItem) {
+            return  $item
+        }
+        return $true
     }
 
     if ($ReturnItem) {
-        if ($statusCode -eq 200) {
-            return  $item, $statusCode
-        }
-        else {
-            return  $null, $statusCode
+        # if we failed to get the file, report back the status code and/or return true/false
+        if (!$NoStatus.IsPresent) {
+            Set-PodeResponseStatus -Code $statusCode
         }
+        return  $null
     }
-
-    return ($statusCode -eq 200)
-
+    return $false
 }
 
 function Test-PodePathIsFile {

diff --git a/src/Private/Responses.ps1 b/src/Private/Responses.ps1
@@ -161,10 +161,9 @@ function Write-PodeFileResponseInternal {
     )
 
     # Attempt to retrieve information about the path
-    $pathInfo , $statusCode = Test-PodePath -Path $Path -Force -ReturnItem -FailOnDirectory:(!$FileBrowser) -NoStatus
+    $pathInfo = Test-PodePath -Path $Path -Force -ReturnItem -FailOnDirectory:(!$FileBrowser)
 
     if (!$pathinfo) {
-        Set-PodeResponseStatus -Code $statusCode
         return
     }
 
@@ -425,10 +424,9 @@ function Write-PodeAttachmentResponseInternal {
     )
 
     # Attempt to retrieve information about the path
-    $pathInfo , $statusCode = Test-PodePath -Path $Path -Force -ReturnItem -FailOnDirectory:(!$FileBrowser) -NoStatus
+    $pathInfo = Test-PodePath -Path $Path -Force -ReturnItem -FailOnDirectory:(!$FileBrowser)
 
     if (!$pathinfo) {
-        Set-PodeResponseStatus -Code $statusCode
         return
     }