This repository was archived by the owner on Oct 19, 2024. It is now read-only.
Sourcery refactored master branch #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| def toFormat(format = ["Json", "Raw String"]): | ||
| def toFormat(self): |
There was a problem hiding this comment.
Function DataVault.toFormat refactored with the following changes:
- The first argument to instance methods should be
self(instance-method-first-arg-name)
| return f"El parametro 'path' no posee un formato valido. Proporciona una ruta de sistema" | ||
| return "El parametro 'path' no posee un formato valido. Proporciona una ruta de sistema" |
There was a problem hiding this comment.
Function Compressor.__init__ refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
Comment on lines
-301
to
+303
|
|
||
| if _ and file_name: | ||
|
|
There was a problem hiding this comment.
Function Notepad.saveToFile refactored with the following changes:
- Hoist repeated code outside conditional statement (
hoist-statement-from-if)
Comment on lines
-346
to
-347
| else: | ||
| pass |
There was a problem hiding this comment.
Function Notepad.clearText refactored with the following changes:
- Remove redundant pass statement (
remove-redundant-pass)
Comment on lines
-356
to
+358
| extra_selections=[] | ||
|
|
||
| #*Aseguramos que el texto se pueda modificar | ||
| if ok and not self.text_field.isReadOnly(): | ||
| #*Mueve el cursor al principio del texto | ||
| self.text_field.moveCursor(QTextCursor.Start) | ||
| color= QColor(Qt.yellow) | ||
| extra_selections=[] | ||
|
|
There was a problem hiding this comment.
Function Notepad.findTextDialog refactored with the following changes:
- Move assignments closer to their usage (
move-assign)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!