Adding storeLargeFileFromLocalContentAsync method to B2StorageClient #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This behaves like `storeLargeFileFromLocalContent` but returns a cancellable future which will prevent additional tasks from starting and attempt to cancel in-progress API calls. Addresses #16
certainmagic
reviewed
Feb 5, 2021
core/src/main/java/com/backblaze/b2/client/B2CancellationToken.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/backblaze/b2/client/B2LargeFileStorer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/backblaze/b2/client/B2LargeFileStorer.java
Outdated
Show resolved
Hide resolved
certainmagic
approved these changes
Feb 9, 2021
tiwijo
approved these changes
Feb 10, 2021
| } | ||
| @Test | ||
| public void testPassthroughMethods() throws B2Exception, IOException { | ||
| cancellableContentSource.getContentLength(); |
There was a problem hiding this comment.
For the passthrough tests, it would be stronger to also check the return values/side-effects.
|
|
||
| @Test(expected = IOException.class) | ||
| public void testInputStreamReadCancelled() throws B2Exception, IOException { | ||
| final InputStream inputStream = cancellableContentSource.createInputStream(); |
There was a problem hiding this comment.
You can tell me if I'm being too annoying, but it might be a stronger test if we set up the ExpectedException right before we call read(). Especially since an earlier commit had exceptions getting thrown in both cancel() and read().
There was a problem hiding this comment.
you're not being annoying -- its an annoying change but the right one. Thanks for pointing this out.
|
|
||
| @Test | ||
| public void testStoreFileAsyncCancelled() throws B2Exception, IOException, ExecutionException, InterruptedException { | ||
| final List<B2PartStorer> partStorers = new ArrayList<>(); |
ericjding
added a commit
that referenced
this pull request
May 10, 2021
* Update CHANGELOG.md to include release 4.0.0 * disable content compression so as not to automatically decompress compressed content (#142) * disable content compression so as not to automatically decompress compressed content in getContent * add more explanation to setContentCompressionEnabled(false) * new comments for setContentCompressionEnabled(false) * bump major version and update CHANGELOG * fix grammar -> by default * adding suffix SNAPSHOT to major version * create B2Json version of ByteArrayOutputStream and throws IOException… (#143) * create B2Json version of ByteArrayOutputStream and throws IOException(Requested array size exceeds maximum limit) * use smaller MAX_ARRAY_SIZE for unit test to avoid OOM error in builds * revisions based on comments from ab, malay * rewrite and rename B2JsonByteArrayOutputStream to B2JsonBoundedByteArrayOutputStream * more revisions for B2JsonBoundedByteArrayOutputStream.java * revisions based on brianb's comments and other discussions * add more comments on the technical context of throwing IOException for B2JsonBoundedByteArrayOutputStream * revised internal implementation of B2JsonBoundedByteArrayOutputStream; add tests for maxCapacity 0, integer overflow; other revision based on comments * remove tests to catch IOException for integer overflow since it causes Travis CI build failure * add index bounds check, fix bug where maxCapacity is not a power of 2 * refactor parameter length for checkCapacity * Adding storeLargeFileFromLocalContentAsync method to B2StorageClient (#145) * Adding storeLargeFileFromLocalContentAsync method to B2StorageClient This behaves like `storeLargeFileFromLocalContent` but returns a cancellable future which will prevent additional tasks from starting and attempt to cancel in-progress API calls. * fix B2LargeFileStorerTest * update Changelog for 5.0.0 release * update version.txt for 5.0.0 release Co-authored-by: Keith Felt <[email protected]> Co-authored-by: keithele <[email protected]> Co-authored-by: mxue-BB <[email protected]> Co-authored-by: malaysf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behaves like
storeLargeFileFromLocalContentbut returns a cancellable future which will prevent additional tasks from starting and attempt to cancel in-progress API calls.Addresses #16