Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support file organization using folder reference #249

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

GMinucci
Copy link
Collaborator

@GMinucci GMinucci commented Jan 23, 2025

What does this PR do

Removes the option for a list of targets in the iOS configuration from variants.yml
Improves PBXGroup creation to allow variants files to be organized in folder reference
Fixes the issues of added files not being included in the main target

How can it be tested

In a new project, run the init command, configure the variants.yml with test values and run the switch command. Once the command is done, confirm that the files are properly added to the .xcodeproj and the build phase is also including the newly generated files.

Task

resolves #244

Additional notes

Reasoning behind removal of list of targets in favor of a single target

Although we have option to provide a list of target this was never implemented. Providing more than one target would lead to unwanted behaviors.
We had the choice to implement the functionality or to remove it completely. If we add it, this means that variants would scale exponentially with the number of targets since variants are applied to all targets. Since the idea of variants is to extend the targets to allow multiple variants, this support would be redundant so we opted to avoid it and remove it completely.
This will also pave the way toward the upcoming functionality related to signing extensions. Since they are also handled as targets in xcode, keeping the target in variants.yml as a list would lead to confusion.

Checklist:

  • I ran make validation locally with success
  • I have not introduced new bugs
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new errors

@GMinucci GMinucci self-assigned this Jan 23, 2025
Copy link

github-actions bot commented Jan 23, 2025

Warnings
⚠️ Pull request is relatively big. If this PR contains multiple changes, consider splitting it into separate PRs for easier reviews.

Generated by 🚫 Danger Swift against 77c496e

@GMinucci GMinucci changed the title Feat/169 multiple bundle support Feat: support file organization using folder reference Jan 23, 2025
@GMinucci GMinucci merged commit 7e39737 into develop Jan 27, 2025
12 checks passed
@GMinucci GMinucci deleted the feat/169-multiple-bundle-support branch January 27, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Xcode folder reference breaks the tool
2 participants