Skip to content

Commit

Permalink
fix: linter and danger errors
Browse files Browse the repository at this point in the history
  • Loading branch information
GMinucci committed Jan 27, 2025
1 parent d909fa8 commit 7a9b473
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 7 deletions.
4 changes: 4 additions & 0 deletions Sources/VariantsCore/Factory/iOS/XCConfigFactory.swift
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
// Created by Arthur Alves
//

// swiftlint:disable file_length

import Foundation
import ArgumentParser
import PathKit
Expand Down Expand Up @@ -255,3 +257,5 @@ class XCConfigFactory: XCFactory {
let xcconfigFileName: String = "variants.xcconfig"
let logger: Logger
}

// swiftlint:enable file_length
4 changes: 2 additions & 2 deletions Sources/VariantsCore/Schemas/iOS/iOSExtension.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//
// iOSExtension.swift
// VariantsCore
// Variants
//
// Copyright (c) Backbase B.V. - https://www.backbase.com
// Created by Gabriel Rodrigues Minucci on 24/01/2025.
//

Expand Down
6 changes: 2 additions & 4 deletions Tests/VariantsCoreTests/iOSTargetExtensionTests.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//
// iOSTargetExtensionTests.swift
// VariantsCoreTests
// Variants
//
// Copyright (c) Backbase B.V. - https://www.backbase.com
// Created by Gabriel Rodrigues Minucci on 27/01/2025.
//

Expand All @@ -16,7 +16,6 @@ class iOSTargetExtensionTests: XCTestCase {
private let target = iOSTarget(name: "Target Name", app_icon: "AppIcon", bundleId: "com.Company.ValidName", testTarget: "ValidNameTests", source: iOSSource(path: "", info: "", config: ""))

func testTargetExtensionCreationWithBundleSuffix() {
let variantBundleID = "com.test.Application"
guard let variant = try? iOSVariant(
name: name, versionName: "1.0.0", versionNumber: 0, appIcon: nil, appName: nil, storeDestination: "appStore",
idSuffix: "beta", bundleID: nil, globalCustomProperties: nil, variantCustomProperties: nil,
Expand All @@ -40,7 +39,6 @@ class iOSTargetExtensionTests: XCTestCase {
}

func testTargetExtensionCreationWithBundleID() {
let variantBundleID = "com.test.Application"
guard let variant = try? iOSVariant(
name: name, versionName: "1.0.0", versionNumber: 0, appIcon: nil, appName: nil, storeDestination: "appStore",
idSuffix: "beta", bundleID: nil, globalCustomProperties: nil, variantCustomProperties: nil,
Expand Down
2 changes: 1 addition & 1 deletion Tests/VariantsCoreTests/iOSVariantTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ class iOSVariantTests: XCTestCase {
globalSigning: nil, variantSigning: nil, globalPostSwitchScript: nil, variantPostSwitchScript: nil)
}

XCTAssertNoThrow(try makeiOSVariant())
XCTAssertThrowsError(try makeiOSVariant())
}

func testGetDefaultValuesForTargetWithoutSigning() {
Expand Down

0 comments on commit 7a9b473

Please sign in to comment.