Request an authentication token only at join, and using the GETTOKEN action instead of the LIST action. #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generating a token no longer fetches the entire server list. This also instructs the list server to not generate a token for the LIST action, since we're now trying to restrict tokens to a specific server host/port instead of the player IP.
blast007
force-pushed
the
improvement/bzfls3auth
branch
from
311af5a
to
0b65555
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we've used the LIST action to request a player authentication token. This was often wasteful because it requested the entire list of servers as well. We could use the token that was provided along with the server list when joining a game server, so it did at times consolidate two requests down to one. However, we're now aiming to restrict a game token to a specific game server host/port instead of the player's IP address so that we can handle CGNAT.
This change causes the token to only be requested during the join process. Additionally, when paired with the new bzfls3, no token will be generated during the LIST action.