Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint configuration #95

Merged
merged 3 commits into from
Oct 2, 2020
Merged

Eslint configuration #95

merged 3 commits into from
Oct 2, 2020

Conversation

tiago154
Copy link
Contributor

@tiago154 tiago154 commented Oct 1, 2020

#89

Hi. I added eslint and put some rules according to the project.

So to validate the errors, run npm run lint

There is also (npm run lint:fix), where it is possible to apply corrections automatically.

@ROODAY
Copy link
Member

ROODAY commented Oct 2, 2020

@tiago154 Thanks for the PR! One request though, can you resubmit this using yarn? We don't want to have both a package-lock and a yarn-lock file. Thanks!

@tiago154
Copy link
Contributor Author

tiago154 commented Oct 2, 2020

@tiago154 Thanks for the PR! One request though, can you resubmit this using yarn? We don't want to have both a package-lock and a yarn-lock file. Thanks!

@ROODAY Of course! I removed the package-lock.json and updated the yarn.lock

@ROODAY ROODAY merged commit 4c916b1 into BUUPE:src Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants