Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed single quotes from sftp_copy in configuration.json #458

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

victor5lm
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (black and flake8).
  • If a new tamplate was added make sure:
    • Template's schema is added in templates/services.json.
    • Template's pipeline's documentation in assets/reports/md/template.md is added.
    • Results Documentation in assets/reports/results/template.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
  • If you know a new user was added to the SFTP, make sure you added it to templates/sftp_user.json

PR checklist

As per the title, this PR modifies configuration.json by removing single quotes from the sftp_copy field, which were preventing the sftp-copy module from working correctly. This PR closes #448.

@victor5lm victor5lm self-assigned this Mar 7, 2025
@victor5lm victor5lm marked this pull request as ready for review March 7, 2025 15:04
Copy link
Member

@svarona svarona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victor5lm victor5lm merged commit 109dc8a into BU-ISCIII:develop Mar 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

copy-sftp (and finish as well) is copying RAW_NC and TMP_NC to sftp folder
2 participants