Skip to content

Commit

Permalink
v2.1.3
Browse files Browse the repository at this point in the history
  • Loading branch information
guoweilong committed Oct 25, 2017
1 parent bf47c05 commit cd0809f
Show file tree
Hide file tree
Showing 4 changed files with 43 additions and 23 deletions.
42 changes: 26 additions & 16 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -555,9 +555,9 @@ Questions & Answers



###(1) Performance
### (1) Performance

####QA1.1
#### QA1.1

Q: "It takes me days to do the alignment for one lane" ... (Speed-up your alignment)

Expand All @@ -572,7 +572,7 @@ A: Yes, alignment is a time-consuming work, especially because the sequencing de

Ex: samtools merge out.bam in1.bam in2.bam in3.bam

####QA1.2
#### QA1.2

Q: "I would run lots of BS-Seeker2 at the same time on cluster (multiple nodes), how could I reduce the disk load?"

Expand All @@ -587,7 +587,7 @@ un-directional library), and each process would run with 2 threads. User can cha
threads using parameter "--bt-p"/"--bt2-p". For example, "--bt-p 4" will require 8 CPUs in total.


####QA1.4
#### QA1.4

Q: "I check my storage using "df –Th". and /tmp storage using 100%. Why these happening?"

Expand All @@ -599,9 +599,9 @@ improperly.



###(2) Input/Output formats
### (2) Input/Output formats

####QA2.1
#### QA2.1

Q: Is the read sequence in BAM/SAM file is the same as my original one?

Expand All @@ -610,7 +610,7 @@ A: NO. They are different for several reasons.
i. For RRBS, some reads are short because of trimming of the adapters
ii. For read mapping on Crick (-) strand, the reads are in fact the complementary of the original sequence, opposite both in nucleotides and direction

####QA2.2
#### QA2.2

Q: In CGmap files, why some lines shown "--" but not a motif (CG/CHG/CHH), for example:

Expand All @@ -620,13 +620,13 @@ Q: In CGmap files, why some lines shown "--" but not a motif (CG/CHG/CHH), for e
A: In this example, the site 4303713 is "N" in genome, thus we could not decide the explict pattern.


####QA2.3
#### QA2.3

Q: Can BS Seeker 2 accept gzipped INPUT files?

A: From v2.0.5, BS-Seeker2 is able to support input file in gzipped format, with file name end in ".gz".

####QA2.4
#### QA2.4

Q: Each of my CGmap files has between 1,000 and 2,000 positions at which the nucleotide is given without a motif, but
instead just "--" for example:
Expand All @@ -637,7 +637,7 @@ instead just "--" for example:
A: That's because chr1:4303713 on reference genome is 'N'. BS-Seeker2 can not tell it as "CHG" or "CHH".


####QA2.5
#### QA2.5

Q: When using bs_seeker2-call_methylation.py, can I only generate CGmap files, without generating other formats?

Expand Down Expand Up @@ -666,9 +666,9 @@ See folowing examples.
python bs_seeker2-call_methylation.py -i WGBS.bam --output=output --db <BSseeker2_path>/bs_utils/reference_genomes/genome.fa_bowtie/


###(3) "Pysam" package related problem
### (3) "Pysam" package related problem

####QA3.1
#### QA3.1

Q: I'm normal account user for Linux(Cluster). I can't install "pysam". I get following error massages:

Expand Down Expand Up @@ -718,7 +718,7 @@ A: You can ask the administrator of your cluster to install pysam. If you don't
unzip BSSeeker2.zip
cd BSseeker2-master/

####QA3.2
#### QA3.2

Q: I came up with the errors

Expand All @@ -733,7 +733,7 @@ Q: I came up with the errors

A: Your pysam seems out of date. I would use pysam version 0.6.x.

####QA3.3
#### QA3.3

Q: I came up with the following error:

Expand All @@ -747,7 +747,7 @@ Q: I came up with the following error:
A: It is very likely that your input file is in a wrong format.


####QA3.4
#### QA3.4

Q: When running bs_seeker2-call_methylation.py with -x option, an error occurred as following:

Expand All @@ -762,7 +762,7 @@ error when using pysam v0.7.4. We haven't test other pysam versions, and are ver
it works on other versions.


####QA3.5
#### QA3.5

Q: What's my pysam version?

Expand All @@ -772,6 +772,16 @@ A: Open python interpreter, and enter the following commands:
>>pysam.__version__


#### QA3.6

Q: I tried bs_seeker2-call_methylation.py, found the read depth in CGmap file is always lower than 8000,
where the reads shall be much higher. (Thanks Xuning Wang for figuring this problem and solve it)

A: It is related by with parameter in pileup function parsing to "pysam". In the v2.1.3 and later, option "-D" is added
for "bs_seeker2-call_methylation.py". User could specify higher number of coverage limitation, in trade of costing more
time for processing.


###(4) Configuration of BS-Seeker2

####QA4.1
Expand Down
10 changes: 7 additions & 3 deletions RELEASE_NOTES
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,15 @@ V2.1.0 - Dec 9, 2016

------------------------------------------

V2.1.1 - Apr. 13th, 2017
V2.1.1 - Apr. 13rd, 2017
1. [bs_seeker2-call_methylation.py] : fixed bug related with pysam version
2. [bs_seeker2-call_methylation.py] : modified output strategies

------------------------------------------

V2.1.2 - Apr. 13th, 2017
1. [bs_seeker2-align.py] : Add option "--XSteve", alternative filtering method proposed by Prof.ß Steve Jacobson
V2.1.2 - Jun. 23rd, 2017
1. [bs_seeker2-align.py] : Add option "--XSteve", alternative filtering method proposed by Prof. Steve Jacobson


V2.1.3 - Oct. 25th, 2017
1. [bs_seeker2-call_methylation.py] : Add option "-d", allow user-defined highest coverage.
12 changes: 9 additions & 3 deletions bs_seeker2-call_methylation.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,16 @@ def context_calling(seq, position):
parser.add_option("-r", "--read-no",type = "int", dest="read_no",
help="The least number of reads covering one site to be shown in wig file "
"[Default: %default]", default = 1)
parser.add_option("-D", "--pileup-maxdepth",type = "int", dest="PileupMaxDepth",
help="The max number of read depth can be called for each position. Parameter passing to pysam. "
"Large number costs more time."
"[Default: %default]", default = 8000)
parser.add_option("-v", "--version", action="store_true", dest="version",
help="show version of BS-Seeker2", metavar="version", default = False)

#
(options, args) = parser.parse_args()
#

#
# if no options were given by the user, print help and exit
if len(sys.argv) == 1:
parser.print_help()
Expand Down Expand Up @@ -188,6 +192,7 @@ def context_calling(seq, position):
options_read_no = options.read_no
options_RM_SX = options.RM_SX
options_RM_OVERLAP = options.RM_OVERLAP
PileupMaxDepth = options.PileupMaxDepth
#
if options.wig_file is not None :
wiggle.write('track type=wiggle_0\n')
Expand Down Expand Up @@ -224,7 +229,7 @@ def context_calling(seq, position):
#
cnts = lambda d: '\t'.join(str(d[n]) for n in nucs)
#
for col in sorted_input.pileup():
for col in sorted_input.pileup(max_depth=PileupMaxDepth):
col_chrom = sorted_input.getrname(col.tid)
col_pos = col.pos
if chrom != col_chrom:
Expand Down Expand Up @@ -401,4 +406,5 @@ def context_calling(seq, position):
logm(' ATCGMap: %s' % options.ATCGmap_file)
if options.CGmap_file is not None:
logm(' CGmap: %s' % options.CGmap_file)
#
#
2 changes: 1 addition & 1 deletion bs_utils/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def reverse_compl_seq(strseq):

def show_version() :
print ""
print " BS-Seeker2 v2.1.2 - Jun 06, 2017"
print " BS-Seeker2 v2.1.3 - Oct. 25, 2017"
print ""


Expand Down

0 comments on commit cd0809f

Please sign in to comment.