This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Feat/lostandfound [#7] #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
public enum State {
LOST,
FOUND
}
public enum Process {
IN_PROGRESS,
FINISHED
}State와 Process의 enum입니다. LOST면 IN_PROGRESS이고 FOUND이면 FINISHED 아닌가요? 두개를 분리해서 사용하는 이유가 궁금합니다. |
min050410
reviewed
Jul 22, 2023
src/main/java/bssm/bsm/domain/board/lostfound/presentation/LostFoundInformationController.java
Outdated
Show resolved
Hide resolved
Comment on lines
23
to
25
| @DeleteMapping("/{id}") | ||
| public LostFoundRes updateProcess(@PathVariable Long id) { | ||
| return lostFoundDefinitionService.updateProcess(id); |
There was a problem hiding this comment.
PutMapping에서 DeleteMapping으로 변경하신 이유가 있나요?
There was a problem hiding this comment.
process가 Fininsh로 바뀌는 것이 사용자관점에서 삭제를 하는 것으로 보고 바꾸었습니다.
src/main/java/bssm/bsm/domain/board/lostfound/presentation/dto/res/LostFoundCompactRes.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LostFound기능을 재정비 하였습니다
progress 대신 State로 습득물 분실물을 구분하고
softDelete처리를 progress 를 기준으로 하였습니다.
또한 api를 Restful하게 수정 했습니다
close #7