-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor sqlite3 to SQLAlchemy #159
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
==========================================
+ Coverage 73.01% 74.59% +1.57%
==========================================
Files 89 89
Lines 7872 7653 -219
==========================================
- Hits 5748 5709 -39
+ Misses 2124 1944 -180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
23f157f
to
35486fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read the code but didn't find anything that looked odd or out of its place. Nice simplification and it's impressive how much code was deleted here (minus 463 lines of code, adding only 71). I assume some of those functions removed were never used?
Yes, many methods of the history db manager were never used. I'll continue that history module refactor on another since this one seems pretty clean. |
The purpose of this PR is to remove the usage of the sqlite3 and use SQLAlchemy instead. We will exclude the refactor of the
history
module to another branch.autosubmit_api/database/db_structure.py
autosubmit_api/experiment/common_db_requests.py