Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor db_common module #153

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Refactor db_common module #153

merged 5 commits into from
Dec 9, 2024

Conversation

LuiggiTenorioK
Copy link
Member

@LuiggiTenorioK LuiggiTenorioK commented Dec 3, 2024

There are some high-level issues in this module that can be solved by using SQLAlchemy and applying the repository pattern.

Tasks:

  • Include new search function in the join repository pattern
  • Use experiment repository when needed
    • search by expid
    • get version
  • Update search handlers to use the new join repository
    • v4 experiments search
    • v3 search
    • v3 running experiments
  • remove dead code

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.38%. Comparing base (9b97fe1) to head (d4fcff5).

Files with missing lines Patch % Lines
autosubmit_api/experiment/common_requests.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   71.75%   72.38%   +0.63%     
==========================================
  Files          86       86              
  Lines        7956     7765     -191     
==========================================
- Hits         5709     5621      -88     
+ Misses       2247     2144     -103     
Flag Coverage Δ
fast-tests 72.38% <96.49%> (+0.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuiggiTenorioK LuiggiTenorioK marked this pull request as ready for review December 5, 2024 19:12
@LuiggiTenorioK LuiggiTenorioK self-assigned this Dec 5, 2024
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the code here I see nothing that I'd change, nor that looks wrong/weird 👏 👏 👏 +1!

@LuiggiTenorioK LuiggiTenorioK merged commit cb68fba into main Dec 9, 2024
9 checks passed
@kinow kinow deleted the refactor-db-common branch December 9, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants