-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralize existing SQLAlchemy snippets in repository layer #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuiggiTenorioK
force-pushed
the
gh-142-centralize-sqlalchemy
branch
from
November 20, 2024 10:00
3f45f6f
to
21ad183
Compare
LuiggiTenorioK
force-pushed
the
gh-142-centralize-sqlalchemy
branch
from
December 10, 2024 09:58
21ad183
to
456337f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 72.38% 72.96% +0.57%
==========================================
Files 86 89 +3
Lines 7765 7872 +107
==========================================
+ Hits 5621 5744 +123
+ Misses 2144 2128 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LuiggiTenorioK
force-pushed
the
gh-142-centralize-sqlalchemy
branch
from
December 10, 2024 13:57
456337f
to
2b025a6
Compare
LuiggiTenorioK
force-pushed
the
gh-142-centralize-sqlalchemy
branch
from
December 10, 2024 14:59
83d6d5e
to
078dd4a
Compare
LuiggiTenorioK
force-pushed
the
gh-142-centralize-sqlalchemy
branch
from
December 11, 2024 15:24
ccab24d
to
4531c30
Compare
LuiggiTenorioK
added
testing
The development is ready to test or already under testing
and removed
working on
Someone is working on it
labels
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #142, we are going to move all the SQLAlchemy operations to the repository layer without changing any behaivor.