Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize existing SQLAlchemy snippets in repository layer #145

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

LuiggiTenorioK
Copy link
Member

As described in #142, we are going to move all the SQLAlchemy operations to the repository layer without changing any behaivor.

@LuiggiTenorioK LuiggiTenorioK self-assigned this Nov 20, 2024
@LuiggiTenorioK LuiggiTenorioK added the working on Someone is working on it label Nov 20, 2024
@LuiggiTenorioK LuiggiTenorioK added this to the API 4.0.1 milestone Nov 20, 2024
@LuiggiTenorioK LuiggiTenorioK force-pushed the gh-142-centralize-sqlalchemy branch from 3f45f6f to 21ad183 Compare November 20, 2024 10:00
@LuiggiTenorioK LuiggiTenorioK force-pushed the gh-142-centralize-sqlalchemy branch from 21ad183 to 456337f Compare December 10, 2024 09:58
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 94.17476% with 12 lines in your changes missing coverage. Please review.

Project coverage is 72.96%. Comparing base (e48d4dc) to head (4531c30).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
autosubmit_api/bgtasks/tasks/status_updater.py 78.94% 4 Missing ⚠️
autosubmit_api/repositories/experiment_status.py 94.36% 4 Missing ⚠️
autosubmit_api/builders/experiment_builder.py 75.00% 2 Missing ⚠️
autosubmit_api/repositories/experiment_details.py 97.82% 1 Missing ⚠️
...mit_api/workers/business/process_graph_drawings.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   72.38%   72.96%   +0.57%     
==========================================
  Files          86       89       +3     
  Lines        7765     7872     +107     
==========================================
+ Hits         5621     5744     +123     
+ Misses       2144     2128      -16     
Flag Coverage Δ
fast-tests 72.96% <94.17%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuiggiTenorioK LuiggiTenorioK force-pushed the gh-142-centralize-sqlalchemy branch from 456337f to 2b025a6 Compare December 10, 2024 13:57
@LuiggiTenorioK LuiggiTenorioK force-pushed the gh-142-centralize-sqlalchemy branch from 83d6d5e to 078dd4a Compare December 10, 2024 14:59
@LuiggiTenorioK LuiggiTenorioK force-pushed the gh-142-centralize-sqlalchemy branch from ccab24d to 4531c30 Compare December 11, 2024 15:24
@LuiggiTenorioK LuiggiTenorioK marked this pull request as ready for review December 11, 2024 15:30
@LuiggiTenorioK LuiggiTenorioK added testing The development is ready to test or already under testing and removed working on Someone is working on it labels Dec 12, 2024
@LuiggiTenorioK LuiggiTenorioK merged commit 00c1821 into main Dec 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing The development is ready to test or already under testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants