Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring and fixes #17

Merged
merged 5 commits into from
May 22, 2024
Merged

Refactoring and fixes #17

merged 5 commits into from
May 22, 2024

Conversation

voroscsoki
Copy link
Contributor

No description provided.

@voroscsoki voroscsoki self-assigned this May 22, 2024
@voroscsoki voroscsoki marked this pull request as ready for review May 22, 2024 17:34
@voroscsoki voroscsoki requested a review from LaciProg May 22, 2024 17:34
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
9.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

LaciProg
LaciProg approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@LaciProg LaciProg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactoring

@voroscsoki voroscsoki merged commit 3f5ddc6 into main May 22, 2024
4 of 5 checks passed
@voroscsoki voroscsoki deleted the fixes branch May 22, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaciProg LaciProg LaciProg approved these changes

Assignees

@voroscsoki voroscsoki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voroscsoki @LaciProg