Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tesztek készítése #14

Merged
merged 5 commits into from
May 21, 2024
Merged

Unit tesztek készítése #14

merged 5 commits into from
May 21, 2024

Conversation

MartonEmese
Copy link
Contributor

No description provided.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MartonEmese
Copy link
Contributor Author

MartonEmese commented May 20, 2024

Closes #1

@MartonEmese MartonEmese requested a review from LaciProg May 20, 2024 19:28
@MartonEmese MartonEmese linked an issue May 20, 2024 that may be closed by this pull request
Copy link
Contributor

@LaciProg LaciProg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall really nice job

@@ -56,6 +56,9 @@ public class Controller {
* Getter for test
* */
public static boolean isTest() {return test;}

public static void setTest(boolean value){ test = value;}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok


public ArrayList<Pipe> getPipes() { return pipes; }

public boolean getEnd() { return end; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice jib

@MartonEmese MartonEmese self-assigned this May 20, 2024
@voroscsoki voroscsoki merged commit 61abcd1 into main May 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tesztek készítése
3 participants