Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonar fixes #13

Merged
merged 13 commits into from
May 21, 2024
Merged

Sonar fixes #13

merged 13 commits into from
May 21, 2024

Conversation

LaciProg
Copy link
Contributor

@LaciProg LaciProg commented May 20, 2024

The final changes with the project files. Every change that was created to refactor the code to improve the quality. Used techniques are: manual review, SanarLint, SonarCloud. Close #6

@LaciProg LaciProg linked an issue May 20, 2024 that may be closed by this pull request
@LaciProg LaciProg self-assigned this May 20, 2024
@LaciProg LaciProg requested a review from MartonEmese May 20, 2024 19:15
Copy link
Contributor

@MartonEmese MartonEmese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minden változtatás/kiegészítés alapos volt és jól sikerült. Szép munka!

@@ -4,6 +4,7 @@ on:
branches:
- main
- Manuális-és-statikus-ellenőrzés
- Sonar-Fixes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rendben, jól látható, hogy itt folytatódott a munka.


package StringResource;

public final class StringResourceController {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minden stimmel!

saboteur Sab1 C
addplayer C Sab1
saboteur Sab2 AB
addplayer AB Sab2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minden változtatott fájl jónak tűnt.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
3.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

# Conflicts:
#	.gitignore
#	Sivatagi vizhalozatok uzemeltetese a gyakorlatban 2/src/Controll/Menu.java
#	Sivatagi vizhalozatok uzemeltetese a gyakorlatban 2/src/Controll/ViewGame.java
#	Sivatagi vizhalozatok uzemeltetese a gyakorlatban 2/src/Controll/WaterCounter.java
#	src/palya.txt
@voroscsoki voroscsoki merged commit f166cd0 into main May 21, 2024
0 of 4 checks passed
@voroscsoki voroscsoki deleted the Sonar-Fixes branch May 21, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manuális és statikus ellenőrzés
3 participants