-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonar fixes #13
Sonar fixes #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minden változtatás/kiegészítés alapos volt és jól sikerült. Szép munka!
@@ -4,6 +4,7 @@ on: | |||
branches: | |||
- main | |||
- Manuális-és-statikus-ellenőrzés | |||
- Sonar-Fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rendben, jól látható, hogy itt folytatódott a munka.
|
||
package StringResource; | ||
|
||
public final class StringResourceController { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minden stimmel!
saboteur Sab1 C | ||
addplayer C Sab1 | ||
saboteur Sab2 AB | ||
addplayer AB Sab2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minden változtatott fájl jónak tűnt.
Quality Gate failedFailed conditions |
# Conflicts: # .gitignore # Sivatagi vizhalozatok uzemeltetese a gyakorlatban 2/src/Controll/Menu.java # Sivatagi vizhalozatok uzemeltetese a gyakorlatban 2/src/Controll/ViewGame.java # Sivatagi vizhalozatok uzemeltetese a gyakorlatban 2/src/Controll/WaterCounter.java # src/palya.txt
The final changes with the project files. Every change that was created to refactor the code to improve the quality. Used techniques are: manual review, SanarLint, SonarCloud. Close #6