Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue-2 - Sonar #8

Merged
merged 25 commits into from
May 22, 2024
Merged

Feature/issue-2 - Sonar #8

merged 25 commits into from
May 22, 2024

Conversation

Tenyitamas
Copy link
Contributor

No description provided.

Tényi Tamás and others added 23 commits May 11, 2024 16:06
Add src directory
7e93853
@Tenyitamas
Add jacoco and sample unit test
1dac3ce
@Tenyitamas
Add new test, introduce DI
26f2348
@Tenyitamas
Add further test cases to Pipe
bce01f0
@Takibalu
Create PumpTest.java
ccd4500
@Takibalu
Update PumpTest
70a2cf2
@Takibalu
Fix tests and fix picture loading, controller DI in Pump.java
10eaf90
@Takibalu
Clean up all Security Hotspot, Controller suspicious calls
8058f5a
@Takibalu
Strings to final fields
6056b64
@Takibalu
Add tests to PumpTest, Capitalize enums
6f66081
@Takibalu
More high severity Issue fixed, Complex methods to smaller ones
b3266fd
@Takibalu
More test to PumpTest and little renames
877e6b4
@Takibalu
Duplicate fixes
f55f7a2
@Takibalu
Started CisternTest
1a28181
@Takibalu
Fix Test
b34b815
@Takibalu
Delete gameview from test
59efb3f
@Takibalu
Fix CisternTest 2
38f47c2
@Takibalu
Cistern problems
f870339
@Takibalu
Format Controller, rename packages
146fdf8
@Takibalu
Fix more High Severity Sonar Issue, auto-format
d69e2e6
@Takibalu
Fix reliability issues
110436c
@Takibalu
fix ArrayOutOfBounds Issue
e81d828
@Takibalu
Reliability fixes
97e087b
@Tenyitamas Tenyitamas requested a review from ernyei13 May 22, 2024 13:25
@Takibalu Takibalu changed the title Add src directory Feature/issue-2 - Sonar May 22, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.0% Coverage on New Code (required ≥ 80%)
4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

ernyei13
ernyei13 approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@ernyei13 ernyei13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@Tenyitamas Tenyitamas merged commit 51a0fe2 into main May 22, 2024
2 of 3 checks passed
@Tenyitamas Tenyitamas deleted the feature/issue-2-sonar-integration branch May 22, 2024 14:54
@Takibalu Takibalu linked an issue May 22, 2024 that may be closed by this pull request
Static code analysis #2
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernyei13 ernyei13 ernyei13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static code analysis
3 participants
@Tenyitamas @ernyei13 @Takibalu