Manuális átvizsgálás és statikus analízis lezárása #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A SonarCloud analízise felhívta a figyelmet az üres app.component.scss fájlra. Mivel erre nincs szükség a projektben, így ezt kitöröltem a többiekkel való egyeztetés után.
Fontosnak tartottuk a HTML5 element-ek használatát, így a SonarCloud javaslatára lecseréltem az egyik <div>-et egy <output>-ra
|
kolcsong
approved these changes
May 15, 2024
matesze41nons
approved these changes
May 16, 2024
zolykovacs
reviewed
May 16, 2024
zolykovacs
reviewed
May 16, 2024
There was a problem hiding this comment.
Igen erre itt nincs szükség.
matesze41nons
approved these changes
May 16, 2024
zolykovacs
reviewed
May 16, 2024
zolykovacs
reviewed
May 16, 2024
There was a problem hiding this comment.
Szép és részletes dokumentáció, több ilyen kéne az iparba.👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A FrontEnd átvizsgálása és analizása megtörtént, csapattársaimmal átbeszélve kerestünk megoldást minden felmerült issue-ra.
A dokumentációm elkészítettem.