Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test #14

Merged
merged 11 commits into from
May 22, 2024
Merged

Unit test #14

merged 11 commits into from
May 22, 2024

Conversation

NCsab01
Copy link
Contributor

@NCsab01 NCsab01 commented May 21, 2024

No description provided.

@NCsab01 NCsab01 requested review from barni10102 and CRLJQ8 May 21, 2024 19:21
@sutheo17 sutheo17 linked an issue May 21, 2024 that may be closed by this pull request
Unit tests for the project #3
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
16.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

CRLJQ8
CRLJQ8 approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@CRLJQ8 CRLJQ8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good, but the coverage of the unit tests is low. However the code of the view is the biggest part of the source code and does not to be tested.

@CRLJQ8 CRLJQ8 merged commit 5080094 into main May 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CRLJQ8 CRLJQ8 CRLJQ8 approved these changes

@barni10102 barni10102 Awaiting requested review from barni10102

Assignees

@barni10102 barni10102

@NCsab01 NCsab01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit tests for the project
5 participants
@NCsab01 @CRLJQ8 @barni10102 @RabaTamas @gerencsermate