2 manuális kód átvizsgálás statikus analízis #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…//github.com/BME-MIT-IET/iet-hf-2024-goon-squad into 2-manuális-kód-átvizsgálás-statikus-analízis
… helper functions
…n-squad into 2-manuális-kód-átvizsgálás-statikus-analízis
kalocsaadi
approved these changes
May 17, 2024
| @@ -73,77 +74,68 @@ public boolean SetPump(int newIn, int newOut) | |||
| } | |||
|
|
|||
| //Ezt a függvényt hívja meg egy passzív elem a pumpalehelyezés elvégzéséhez | |||
| public boolean Insert(Passive oldPassive) | |||
| { | |||
| public boolean Insert(Passive oldPassive) { | |||
There was a problem hiding this comment.
Good idea to split it up, easier to read.
There was a problem hiding this comment.
Main was a god class, separating the rendering process was necessary.
| @@ -3,6 +3,7 @@ | |||
| public class Pipe extends Passive implements Notifiable{ | |||
| private boolean hasPlayer = false; | |||
| private PipeState state = PipeState.NORMAL; | |||
| private Random random = new Random(); | |||
There was a problem hiding this comment.
Singular initialization is efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented needed changes to solve problems found by using static analysis (SonarLint, ErrorLens).