Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ABLASTR & pyAMReX #715

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Update ABLASTR & pyAMReX #715

merged 6 commits into from
Sep 30, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Sep 25, 2024

To latest commit on development each.

@ax3l ax3l added the component: third party Changes in ImpactX that reflect a change in a third-party library label Sep 25, 2024
@ax3l ax3l requested review from RemiLehe and EZoni September 25, 2024 08:06
@ax3l ax3l force-pushed the update-deps branch 2 times, most recently from 544467a to b9e794a Compare September 25, 2024 08:38
@ax3l
Copy link
Member Author

ax3l commented Sep 25, 2024

@ax3l
Copy link
Member Author

ax3l commented Sep 25, 2024

Investigating if the changes in ECP-WarpX/WarpX#5284 just need a slightly higher tolerance now or if we cut too close to the beam.

@ax3l
Copy link
Member Author

ax3l commented Sep 25, 2024

@RemiLehe even if I increase resolution (amr.n_cell), wrapping around the beam geometry.prob_relative
https://github.com/ECP-WarpX/impactx/blob/3a8ab8dc981aafccc9ab3de167e222d986f8b374/examples/cfchannel/input_cfchannel_10nC_fft.in#L43-L45
and rtol I do not et it to pass our tolerance again so far:
https://github.com/ECP-WarpX/impactx/blob/3a8ab8dc981aafccc9ab3de167e222d986f8b374/examples/cfchannel/analysis_cfchannel_10nC.py#L82

We expect these values:

    [sigx, sigy, sigt, emittance_x, emittance_y, emittance_t] ==
    [
        1.2154443728379865788e-003,
        1.2154443728379865788e-003,
        4.0956844276541331005317e-004,
        1.000000000e-006,
        1.000000000e-006,
        1.000000000e-006,
    ]

and I see these:

    [
        0.00111891388596667,
        0.0011285746858011444,
        0.0003732679938919104,
        9.993789938274477e-07,
        1.0106011946996333e-06,
        1.0016124683067494e-06
    ]

@EZoni
Copy link
Member

EZoni commented Sep 25, 2024

I was thinking that another possibility to check this would be to switch on/off the change of ECP-WarpX/WarpX#5284 (a one-line change) locally and see what effect it has on a given test that currently fails, if you haven't already tried.

@ax3l
Copy link
Member Author

ax3l commented Sep 25, 2024

Thanks @EZoni - that line causes the issue.

@ax3l ax3l requested a review from cemitch99 September 30, 2024 16:48
@ax3l
Copy link
Member Author

ax3l commented Sep 30, 2024

CUDA issue needs ECP-WarpX/WarpX#5346 to fix

@ax3l ax3l merged commit 7a0b326 into BLAST-ImpactX:development Sep 30, 2024
16 checks passed
@ax3l ax3l deleted the update-deps branch September 30, 2024 23:44
@ax3l
Copy link
Member Author

ax3l commented Sep 30, 2024

yay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: third party Changes in ImpactX that reflect a change in a third-party library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants