Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trame Dashboard #651

Merged
merged 112 commits into from
Aug 9, 2024
Merged

Trame Dashboard #651

merged 112 commits into from
Aug 9, 2024

Conversation

proy30
Copy link
Member

@proy30 proy30 commented Jul 22, 2024

Added a trame dashboard.

@proy30 proy30 marked this pull request as draft July 22, 2024 18:08
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@proy30 proy30 changed the title Added trame dashboard Added Trame Dashboard Jul 22, 2024
@ax3l ax3l changed the title Added Trame Dashboard [WIP] Trame Dashboard Jul 22, 2024
@ax3l ax3l added the component: python Python bindings label Jul 22, 2024
@ax3l ax3l self-requested a review July 22, 2024 21:32
@ax3l ax3l self-assigned this Jul 22, 2024
@ax3l ax3l mentioned this pull request Jul 22, 2024
3 tasks
proy30 added 3 commits August 1, 2024 08:50
Includes the diag files that are generated by simulations, and two temporary files for beam distribution and lattice elements.
Upon clicking the run simulation button, terminal output correctly prints in the terminal view. However, the simulation script is directly called from the terminal view, which is unallowing itself to retrieve the user-inputted valued. Right now, the terminal correctly works only if fixed valued are placed in the script.
@ax3l ax3l added component: dashboard our browser based trame dashboard and removed component: python Python bindings labels Aug 8, 2024
return base64.b64encode(buf.read()).decode("utf-8")


def run_simulation():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a follow-up PR, let's move this out to separate run logic controls.

Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work, congratulations ✨

@ax3l ax3l enabled auto-merge (squash) August 9, 2024 16:42
@ax3l ax3l merged commit 3da80a9 into BLAST-ImpactX:development Aug 9, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard our browser based trame dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants