-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trame Dashboard #651
Trame Dashboard #651
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
for more information, see https://pre-commit.ci
elements module was not loading in, resulting in errors to read latticeElements
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This helps code readability
avoided using return value of a procedure that returns None
for more information, see https://pre-commit.ci
src/python/impactx/dashboard/Input/distributionParametersCard/distributionMain.py
Fixed
Show fixed
Hide fixed
src/python/impactx/dashboard/output_distribution_parameters.txt
Outdated
Show resolved
Hide resolved
src/python/impactx/dashboard/output_latticeElements_parameters.txt
Outdated
Show resolved
Hide resolved
src/python/impactx/dashboard/Input/distributionParametersCard/distributionFunctions.py
Outdated
Show resolved
Hide resolved
src/python/impactx/dashboard/Input/Visualiztion/twiss_phase_space_ellipse/x_px.py
Outdated
Show resolved
Hide resolved
Includes the diag files that are generated by simulations, and two temporary files for beam distribution and lattice elements.
Upon clicking the run simulation button, terminal output correctly prints in the terminal view. However, the simulation script is directly called from the terminal view, which is unallowing itself to retrieve the user-inputted valued. Right now, the terminal correctly works only if fixed valued are placed in the script.
src/python/impactx/dashboard/Analyze/plot_PhaseSpaceProjections/phaseSpace.py
Outdated
Show resolved
Hide resolved
src/python/impactx/dashboard/Analyze/plot_PhaseSpaceProjections/phaseSpace.py
Outdated
Show resolved
Hide resolved
src/python/impactx/dashboard/Analyze/plot_PhaseSpaceProjections/phaseSpace.py
Outdated
Show resolved
Hide resolved
src/python/impactx/dashboard/Analyze/plot_PhaseSpaceProjections/phaseSpace.py
Outdated
Show resolved
Hide resolved
src/python/impactx/dashboard/Analyze/plot_PhaseSpaceProjections/phaseSpace.py
Outdated
Show resolved
Hide resolved
src/python/impactx/dashboard/Input/latticeConfiguration/latticeMain.py
Outdated
Show resolved
Hide resolved
src/python/impactx/dashboard/Input/distributionParameters/twissParameters.txt
Outdated
Show resolved
Hide resolved
src/python/impactx/dashboard/Analyze/plot_PhaseSpaceProjections/phaseSpace.py
Outdated
Show resolved
Hide resolved
And removed functions calls when unneeded
for more information, see https://pre-commit.ci
src/python/impactx/dashboard/Analyze/plot_PhaseSpaceProjections/phaseSpace.py
Outdated
Show resolved
Hide resolved
return base64.b64encode(buf.read()).decode("utf-8") | ||
|
||
|
||
def run_simulation(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a follow-up PR, let's move this out to separate run logic controls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work, congratulations ✨
Added a trame dashboard.