Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Py Extensions & Install .pyi Files #616

Merged
merged 2 commits into from
May 17, 2024
Merged

Fix Py Extensions & Install .pyi Files #616

merged 2 commits into from
May 17, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented May 17, 2024 •
edited
Loading

  • The python runtime extension files did shadow the actual pybind classes we declare for ImpactXParIter and a few others, because the module name was the same.
  • .pyi stub files were not yet installed.
  • add a test

@ax3l
Fix Py Extensions & Install .pyi Files
df83ca3 
- The python runtime extension files did shadow the actual pybind
  classes we declare for `ImpactXParIter` and a few others, because
  the module name was the same.
- `.pyi` stub files were not yet installed.
@ax3l ax3l added bug Something isn't working bug: affects latest release Bug also exists in latest release version component: python Python bindings labels May 17, 2024
@ax3l ax3l requested a review from RTSandberg May 17, 2024 05:53
@ax3l
Add a Test
c39164d 
Ensure low-level particle iteration works.
@ax3l ax3l merged commit 28f37f8 into BLAST-ImpactX:development May 17, 2024
16 checks passed
@ax3l ax3l deleted the fix-py-extensions branch May 17, 2024 06:03
@ax3l ax3l mentioned this pull request May 17, 2024
Merged
RTSandberg
RTSandberg reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@RTSandberg RTSandberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes my issue with the ImpactXParIter name collision and so turning into a module rather than the class I was expecting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RTSandberg RTSandberg RTSandberg left review comments

Assignees
No one assigned
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: python Python bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ax3l @RTSandberg