Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: None -> Empty Element/Dist #593

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Apr 29, 2024

None is a keyword in Python and thus should not be used as a class type for our empty element or our empty distribution. This fixes it by renaming both to Empty.

@ax3l ax3l added bug Something isn't working bug: affects latest release Bug also exists in latest release version component: elements Elements/external fields component: distributions beam distributions component: python Python bindings labels Apr 29, 2024
@ax3l ax3l requested a review from cemitch99 April 29, 2024 02:51
@ax3l ax3l added the changes input scripts / defaults Changes the syntax or meaning of input scripts and/or defaults label Apr 29, 2024
`None` is a keyword in Python and thus should not be used
as a class type for our empty element or our empty distribution.
This fixes it by renaming both to `Empty`.
```
.github/update_stub.sh
```
@ax3l ax3l merged commit 84a1167 into BLAST-ImpactX:development Apr 29, 2024
16 checks passed
@ax3l ax3l deleted the fix-empty branch April 29, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working changes input scripts / defaults Changes the syntax or meaning of input scripts and/or defaults component: distributions beam distributions component: elements Elements/external fields component: python Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant