land the portable implementation of the new blake3_guts crate #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My
guts_apibranch has been around for a while, and it's time that I start figuring out how to land it. The first step will be to land the portable implementation by itself, without anything depending on it. This will get a lot of APIs in place, so that other work can happen in parallel:blake3crate withblake3_guts(this might not land for a while)The longer run questions will be things like "do we want to generate the different flavors of assembly from scripts?" and "how should we support Bao, Bessie, and BLAKE3-AEAD?" This PR is about making step-by-step progress instead of trying to answer all these questions as once.