fix: read LSF_CONFIG_FILE if th user lacks permission to badmin #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-reimonn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Brian!
Our lab has a bug fix / small feature we'd like to contribute to snakemake-executor-plugin-lsf. On our LSF cluster, users don't have access to
badminto raw LSF config. However, we can read a configuration file with the path in the env var LSF_CONFIG_FILE which appears to have the same results. We modifiedget_lsf_configto trybadminand if that fails, try reading the LSF_CONFIG_FILE. This also allows users to provide a new env var and a custom "config" if required.Please let us know if you have any feedback. Thanks!