Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the Devcontainer #192

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Improving the Devcontainer #192

merged 3 commits into from
Feb 13, 2025

Conversation

hoerstl
Copy link
Contributor

@hoerstl hoerstl commented Feb 4, 2025

Issue

Resolves issue #191

Unable to run the app development environment in current state.

URCPP is currently not runnable using the docker container and docker-compose file with myriad of permission issues on the database and inconsistencies between the usernames and passwords being used to make the DB connection.

The repository should be modified to use a .devcontainer folder which sets up the development environment on its own.

Additional changes should address:

  • Move the Dockerfile and docker-compose.yml files to a .devcontainer folder so we can develop in any environment.
  • Storing the code in a volume so we don't need to rebuild every time to copy changed files into our docker image.
  • Fixing permission issues between the database and the app containers. (The app currently doesn't run due to permission issues)
  • Migrating to Python 3 (Scott Heggen made the migration to python 3 using local setup in this PR) within the docker container.

Changes

TBD

To Test

TBD

@hoerstl
Copy link
Contributor Author

hoerstl commented Feb 4, 2025

The dockerfile in the original image is using an official python docker image instead of one from microsoft specifically to be used as a devcontainer. Were we using this to deploy and if so, then changing the image to use a devcontainer image of python might cause issues. - Ask Brian

…ically on container start and when opening a bash terminal.
@hoerstl

This comment was marked as resolved.

@hoerstl
Copy link
Contributor Author

hoerstl commented Feb 6, 2025

Brian just gave me a sidequest to go and fix an issue with all of our devcontainers including this one. When we run flask in development mode, it’s supposed to refresh everytime we make a local change to files. However, while this is the case when hosted locally, docker containers are not noticing the change properly. We’d like to fix that for not only URCPP but for all of our applications.

@BrianRamsay BrianRamsay marked this pull request as ready for review February 13, 2025 16:14
@BrianRamsay BrianRamsay merged commit ec9b131 into development Feb 13, 2025
@BrianRamsay BrianRamsay deleted the devcontainer-setup branch February 13, 2025 16:19
@hoerstl hoerstl mentioned this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants