Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dates to primary checks #341

Open
wants to merge 18 commits into
base: development
Choose a base branch
from

Conversation

bryantal
Copy link
Contributor

This PR includes:

  1. Refactor of supervisor portal tabs to include “Pending”, “Past”, and any active terms based on the end dates of the term. Leverages Datatables to do this filtering (instead of lots of backend code).
  2. Refactor of supervisor portal to include all LSFs (instead of all students). You should see duplicates if a student has more than one LSF given the filter in item 1.
  3. Refactor of supervisor portal’s organization of information.
  4. Fixes the My students menu item to the correct page.
  5. Hotfix of the Labor History buttons for students who are no longer at the college. Should display “Show evaluations” if one exists, otherwise, it should show no buttons and the “No buttons available” warning message.
  6. Fixes the Download button to include all LSFs that are in the Datatable (instead of what the backend says to send, which was not always accurate based on the user’s current view). The Downloader pulls across a paginated table, also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants