-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Position Description Interface #335
Open
bryantal
wants to merge
59
commits into
development
Choose a base branch
from
positionDescription
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bryantal
commented
May 31, 2022
- This PR fixes issue #292 (Task 2 for this issue is not completed but a separate issue is made for it. issue #325 )
- A new interface is now available for both supervisors and labor admins in the sidebar (it is named ‘Position Descriptions’ for both).
- Supervisors are able to view past and current versions of the position description and request and edit to make a newer version.
- Pending requests appear for labor admins and they have the ability to make changes to the fields available and either deny or accept the request.
- Emailing is not being handled in this PR for any of the actions happening in this process
- Changes are made to the database and there are 2 new tables added that will support this new interface.
- Previous position descriptions are added to our local database and we have the export file available as an attachment.
- There are some dummy position descriptions available in the demo data but for more realistic data refer to the attachment.
- Notes: Some position descriptions were not added because they did not have any POSN CODE or WLS but they can be added easily through our interface
- Notes: We are not able to compare our position description data with Tracy as we do with the position table. The records in the position table are not complete. For our work, we only needed the POSN_CODE to be correct. The rest of the data was not needed and not always available in some files as well. We can fix this issue by pulling the positions from TRACY, and updating the records to match the information in TRACY. We can also add in new position from TRACY that we do not have in our tables. Since we could not test without access to TRACY, we did not implement this
- Notes: If you need to use the scripts to add new files, they are located in /database folder and they need to be executed in the following order:
- database/remove_space_file_name.py : in case there is any space in the file name
- database/convert_doc_to_txt.py: To convert doc/docx to a txt file
- database/positionScraper.py : to add the needed field to the database
…-flask into positionDescription
…ents/lsf-flask into positionDescription
…ents/lsf-flask into positionDescription
… Scott and labor, and also finished up half of the new landing page UI
…s, now working on using the new tables Scott recomeneded
… make page cleaner
…-flask into positionDescription
…ents/lsf-flask into positionDescription
…wrap it up with the email handler
…o iterate over files
…-flask into positionDescription
…ents/lsf-flask into positionDescription
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.