[졸업학점계산기] 엑셀 업로더 툴팁 구현 #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 16, 2025 00:10
junghaesung79
approved these changes
Jan 17, 2025
Comment on lines
79
to
81
|
|
||
| &--title { | ||
| font-size: 20px; |
There was a problem hiding this comment.
title이 BEM 컨벤션에서의 modifier의 역할을 하는 건가요?
There was a problem hiding this comment.
오..! 생각해보니 -title 이 더 맞는것 같아요! 수정했습니다!
Comment on lines
+42
to
+49
| </div> | ||
| <button type="button" aria-label="close" className={styles['excel-uploader__tooltip-close']} onClick={handleTooltipCloseButtonClick}> | ||
| <CloseIcon /> | ||
| </button> | ||
| <div className={styles['excel-uploader__tooltip-asset']}> | ||
| <BubbleTailBottom /> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
지금 방법도 좋은데 혹시 이런 방식은 어떤 것 같나요?
툴팁 요소가 어차피 absolute 하니까, tooltip-asset 요소의 자식으로 둔 다음, tooltip-asset에 relative를 주면, top 위치 잡기 편할 것 같아요!
만약 이렇게 한다면 tooltip-asset를 감싸는 새로운 부모 요소에 다시 absolute를 줄 것 같아요.
There was a problem hiding this comment.
만약 이렇게 한다면 tooltip-asset를 감싸는 새로운 부모 요소에 다시 absolute를 줄 것 같아요.
혹시 해당 부분을 다시 설명해주실 수 있으신가요..?
tooltip-asset 부모요소에 absolute 을 주고 tooltip-asset 에 relative, 툴팁에 absolute 을 할당하는 방식을 말하시는 걸까요..?
Yejin0070
approved these changes
Jan 18, 2025
Gwak-Seungju
pushed a commit
that referenced
this pull request
Feb 3, 2025
Co-authored-by: hyejun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍
ScreenShot 📷
✔️ Please check if the PR fulfills these requirements
developbranch unconditionally?main?yarn lint