feat: 상점 카테고리 순서 변경 api 추가 #1007
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krSeonghyeon
requested changes
Nov 12, 2024
| .andExpect(jsonPath("$.total_page").value(2)) | ||
| .andExpect(jsonPath("$.current_page").value(1)) | ||
| .andExpect(jsonPath("$.categories.length()").value(10)); | ||
| .andExpect(content().json(""" |
There was a problem hiding this comment.
R
일반음식점과 치킨의 순서를 바꾸어도 정상적으로 테스트가 완료되네요
json을 사용해서는 검증하기 어려울 것 같습니다
There was a problem hiding this comment.
좋은 피드백 감사합니다.
| @PutMapping("/admin/shops/{shopId}/menus/categories") | ||
| public ResponseEntity<Void> modifyMenuCategory( | ||
| @Parameter(in = PATH) @PathVariable("shopId") Integer shopId, | ||
| @RequestBody @Valid AdminModifyMenuCategoryRequest adminModifyMenuCategoryRequest, |
There was a problem hiding this comment.
수정하다가 신경쓰지 못하고 있었네요 좋은 지적 감사합니다.
| @@ -41,6 +41,9 @@ public class ShopCategory extends BaseEntity { | |||
| @Column(name = "image_url") | |||
| private String imageUrl; | |||
|
|
|||
| @Column(name = "order_index", nullable = false) | |||
There was a problem hiding this comment.
A
Valid 제약조건에 관한 내용도 추가해주면 좋을 것 같습니다
20HyeonsuLee
requested changes
Nov 13, 2024
| @@ -273,6 +270,26 @@ private void validateExistCategoryName(String name, Integer categoryId) { | |||
| } | |||
| } | |||
|
|
|||
| @Transactional | |||
| public void modifyShopCategoriesOrder(AdminModifyShopCategoriesOrderRequest adminModifyShopCategoriesOrderRequest) { | |||
There was a problem hiding this comment.
C
Set의 차집합 연산을 이용하면 코드가 더 깔끔해지지 않을까 싶어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항
한번에 카테고리들을 조회하여 map으로 매핑하는 방식을 사용하였습니다. 중복된 id검증을 위해 매핑되는 것마다 remove를 진행하여 예외를 처리했습니다.
정렬 순서를 저장하는 필드에 유니크 제약 조건을 걸까 생각했지만, 유연하게 처리하고자 따로 걸지는 않았습니다.