Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance by removing EscapeId rule #217

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Improve performance by removing EscapeId rule #217

merged 2 commits into from
Dec 17, 2024

Conversation

dhuebner
Copy link
Collaborator

@dhuebner dhuebner commented Dec 16, 2024 •
edited
Loading

Using keywordToken.CATEGORIES to achieve the same effect as with synthetic EscapeId but with much better performance.

See #216

Other changes:

  • extracted an explicit InterfaceMethodDecl rule as Interface methods don't have body and methodend
  • prevent loading package Javadoc multiple times

@dhuebner dhuebner force-pushed the dhuebner/escapeId-216 branch from 3594d66 to 9da9a6d Compare December 17, 2024 12:01
@dhuebner dhuebner force-pushed the dhuebner/escapeId-216 branch from 9da9a6d to e032d34 Compare December 17, 2024 12:03
@dhuebner dhuebner merged commit 0e28472 into main Dec 17, 2024
1 check passed
@dhuebner dhuebner deleted the dhuebner/escapeId-216 branch December 17, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoenemann spoenemann spoenemann approved these changes

@insafuhrmann insafuhrmann Awaiting requested review from insafuhrmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhuebner @spoenemann